New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On `component install dep` - dep not added to project component.json if already installed #465

Closed
airportyh opened this Issue Jan 23, 2014 · 4 comments

Comments

Projects
None yet
4 participants
@airportyh
Contributor

airportyh commented Jan 23, 2014

Steps to reproduce

  1. component install component/dialog - this installs a bunch of components notably component/dom, it also adds component/dialog as a dep to component.json
  2. component install component/dom - this install does nothing because it already exists, but notably it also does not add component/dom as a dep to component.json - which IMO it should do.
  3. component build
  4. try to require('dom') in a test page and get error Uncaught Error: Failed to require "dom" from "root"
@tj

This comment has been minimized.

Show comment
Hide comment
@tj

tj Jan 23, 2014

Contributor

sounds like a bug to me

Contributor

tj commented Jan 23, 2014

sounds like a bug to me

@KenanY

This comment has been minimized.

Show comment
Hide comment
@KenanY

KenanY Jan 23, 2014

Contributor
Contributor

KenanY commented Jan 23, 2014

airportyh added a commit to airportyh/component that referenced this issue Jan 23, 2014

@jonathanong

This comment has been minimized.

Show comment
Hide comment
@jonathanong

jonathanong Jan 23, 2014

Contributor

the require statements don't really work outside the build. the only real way to solve that is to either create even more aliases or have a super smart require, both of which would fatten the builds.

Contributor

jonathanong commented Jan 23, 2014

the require statements don't really work outside the build. the only real way to solve that is to either create even more aliases or have a super smart require, both of which would fatten the builds.

@airportyh

This comment has been minimized.

Show comment
Hide comment
@airportyh

airportyh Feb 4, 2014

Contributor

Closing as dup of #405.

Contributor

airportyh commented Feb 4, 2014

Closing as dup of #405.

@airportyh airportyh closed this Feb 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment