Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

On component install dep - dep not added to project component.json if already installed #465

Closed
airportyh opened this issue Jan 23, 2014 · 4 comments

Comments

@airportyh
Copy link
Contributor

Steps to reproduce

  1. component install component/dialog - this installs a bunch of components notably component/dom, it also adds component/dialog as a dep to component.json
  2. component install component/dom - this install does nothing because it already exists, but notably it also does not add component/dom as a dep to component.json - which IMO it should do.
  3. component build
  4. try to require('dom') in a test page and get error Uncaught Error: Failed to require "dom" from "root"
@tj
Copy link
Contributor

tj commented Jan 23, 2014

sounds like a bug to me

@kenany
Copy link
Contributor

kenany commented Jan 23, 2014

#405

@jonathanong
Copy link
Contributor

the require statements don't really work outside the build. the only real way to solve that is to either create even more aliases or have a super smart require, both of which would fatten the builds.

@airportyh
Copy link
Contributor Author

Closing as dup of #405.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants