library: Use PaddingValues instead of DpSize; Allow setting Scaffold's popupHost to null (using Scaffold and MiuixPopupHost separately) #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update: Allow setting Scaffold's popupHost to null (using Scaffold and MiuixPopupHost separately)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
去掉了 leftaction 的固定 End Padding（在 leftaction 里自己设置Padding，BasicComponent）
用 PaddingValues 替换 DpSize （允许分别设置四个方向的Padding，BasicComponent）
允许给 Scaffold 传入指定的 popupHost 并且允许为空（把 Scaffold 和 MiuixPopupHost 分离，允许多 Scaffold 和一个独立的 MiuixPopupHost ）