Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project: ensure withServices doesn't blow stack on cycles #274

Merged
merged 1 commit into from Jun 10, 2022

Conversation

nicksieger
Copy link
Member

Change done map to seen and record service was seen before traversing
dependencies.

Fixes docker/compose#9526.

Signed-off-by: Nick Sieger nick@nicksieger.com

Change `done` map to `seen` and record service was seen before traversing
dependencies.

Fixes docker/compose#9526.

Signed-off-by: Nick Sieger <nick@nicksieger.com>
@nicksieger nicksieger requested a review from ndeloof as a code owner Jun 9, 2022
@nicksieger nicksieger requested review from glours and ulyssessouza Jun 9, 2022
@nicksieger nicksieger merged commit 0056c09 into master Jun 10, 2022
9 checks passed
@nicksieger nicksieger deleted the nicksieger/compose/9526 branch Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack overflow when circular references in service definitions
2 participants