Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing LinkLocalIPs to ServiceNetworkConfig #289

Merged
merged 2 commits into from Jul 23, 2022

Conversation

floatingstatic
Copy link
Contributor

Signed-off-by: Jeremiah Millay jmillay@fastly.com

This addresses #288 and I believe is a prerequisite to fixing docker/compose#9659 (happy to take care of that as well once this change is approved/merged).

Signed-off-by: Jeremiah Millay <jmillay@fastly.com>
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you :)

types/types.go Outdated Show resolved Hide resolved
Signed-off-by: Jeremiah Millay <jmillay@fastly.com>
glours
glours approved these changes Jul 23, 2022
@glours glours merged commit 7be7b11 into compose-spec:master Jul 23, 2022
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants