Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: ensure compatibility for all supported Go versions #295

Merged
merged 1 commit into from Jul 29, 2022

Conversation

milas
Copy link
Member

@milas milas commented Jul 29, 2022

Use matrix testing to test on currently supported Go versions,
including 1.19 pre-release.

The go.mod compatibility level is also set to 1.17. Once 1.19
is released, we should bump to 1.18, as Go always supports the
current version and one older, so we should stick with this as
well.

@milas milas added the dependencies Pull requests that update a dependency file label Jul 29, 2022
@milas milas self-assigned this Jul 29, 2022
@milas milas requested a review from ndeloof as a code owner Jul 29, 2022
Use matrix testing to test on currently supported Go versions,
including 1.19 pre-release.

The `go.mod` compatibility level is also set to 1.17. Once 1.19
is released, we should bump to 1.18, as Go always supports the
current version and one older, so we should stick with this as
well.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas
Copy link
Member Author

milas commented Jul 29, 2022

Comment from @AkihiroSuda on #290 made me think we should have coverage here to avoid breaking things by accident.

The test suite is currently pretty fast, but we can always cut the matrix down if running 3x3 (Go x OS) gets to be too much.

@milas milas merged commit 0ab97a2 into compose-spec:master Jul 29, 2022
11 checks passed
@milas milas deleted the golang-versions branch Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants