Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotenv: fix parse error on files with UTF-8 BOM #301

Merged
merged 1 commit into from Sep 6, 2022

Conversation

milas
Copy link
Member

@milas milas commented Sep 2, 2022

Some Windows editors tend to add UTF-8 BOM markers to files,
which breaks parsing of .env files.

Now, when the file is read, if it starts with a UTF-8 BOM,
we'll skip it. (.env files are always processed as UTF-8.)

See docker/compose#9799.

Some Windows editors tend to add UTF-8 BOM markers to files,
which breaks parsing of `.env` files.

Now, when the file is read, if it starts with a UTF-8 BOM,
we'll skip it. (`.env` files are always processed as UTF-8.)

See docker/compose#9799.

Signed-off-by: Milas Bowman <milas.bowman@docker.com>
@milas milas added the bug Something isn't working label Sep 2, 2022
@milas milas requested a review from ndeloof as a code owner Sep 2, 2022
@milas milas self-assigned this Sep 2, 2022
glours
glours approved these changes Sep 6, 2022
@glours glours merged commit 34d8f70 into compose-spec:master Sep 6, 2022
11 checks passed
@milas milas deleted the env-file-utf8-bom branch Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants