dotenv: fix parse error on files with UTF-8 BOM #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Windows editors tend to add UTF-8 BOM markers to files, which breaks parsing of `.env` files. Now, when the file is read, if it starts with a UTF-8 BOM, we'll skip it. (`.env` files are always processed as UTF-8.) See docker/compose#9799. Signed-off-by: Milas Bowman <milas.bowman@docker.com>
nicksieger
approved these changes
Sep 2, 2022
glours
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some Windows editors tend to add UTF-8 BOM markers to files,
which breaks parsing of
.envfiles.Now, when the file is read, if it starts with a UTF-8 BOM,
we'll skip it. (
.envfiles are always processed as UTF-8.)See docker/compose#9799.