Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load from file if ConfigFile.Content is empty #315

Merged
merged 1 commit into from Nov 3, 2022

Conversation

flowchartsman
Copy link
Contributor

@flowchartsman flowchartsman requested a review from ndeloof as a code owner Oct 25, 2022
@milas milas self-assigned this Nov 2, 2022
Copy link
Member

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Can you rebase/amend your commit to include the DCO?

See https://github.com/compose-spec/compose-go/pull/315/checks?check_run_id=9085322040 for details

@milas milas added the bug Something isn't working label Nov 2, 2022
@flowchartsman flowchartsman force-pushed the fix-#314 branch 2 times, most recently from 667860c to 745f56f Compare Nov 3, 2022
@flowchartsman
Copy link
Contributor Author

Good to go (I think)

- fixes compose-spec#314

Signed-off-by: Andy Walker <walkeraj@gmail.com>
@flowchartsman
Copy link
Contributor Author

Now that is one strict DCO rule. Should be good now?

milas
milas approved these changes Nov 3, 2022
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@milas milas merged commit 918dbe8 into compose-spec:master Nov 3, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not load from file with no content bytes.
3 participants