Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check service secrets existence #316

Merged
merged 2 commits into from Nov 7, 2022

Conversation

glours
Copy link
Contributor

@glours glours commented Nov 1, 2022

Regarding the Compose Specification, a secret used at the service level should exist on the platform or be defined in the secrets section

Compose implementations MUST report an error if the secret doesn't exist on the platform or isn't defined in the secrets section of this Compose file.

Also fix bugs in WithoutUnnecessaryResources that created empty resources when a resource declared in service section weren’t existing in the top level declaration (secrets. volumes, networks, configs...)

reference: docker/compose#9963

@glours glours requested a review from ndeloof as a code owner Nov 1, 2022
@glours glours self-assigned this Nov 1, 2022
Copy link
Member

@nicksieger nicksieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, maybe add a couple unit tests in validate_test.go?

glours added 2 commits Nov 2, 2022
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
…tUnnecessaryResources function

Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
@glours glours force-pushed the check-service-secrets branch from 48e4ed6 to a9ba921 Compare Nov 2, 2022
@glours glours requested a review from nicksieger Nov 2, 2022
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@glours glours merged commit 87bd752 into compose-spec:master Nov 7, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants