fixing format of codeblock #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the rest of the file the codeblocks are seperated by the rest of the text by a blank line. As is usually best practice. However in this section it wasn't seperated by a blank line. I changed the format by inserting a blank line to match the rest of the file Signed-off-by: Julian <117523783+dozjul@users.noreply.github.com>
ndeloof
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the rest of the file the codeblocks are seperated by the rest of the text by a blank line. As is usually best practice. However in this section it wasn't seperated by a blank line.
I changed the format by inserting a blank line to match the rest of the file
What this PR does / why we need it:
On https://docs.docker.com/compose/compose-file/build/ the code-block was rendered incorrectly, but only at this one code-block.
A screenshot of the wrongly rendered section is attached below:
I assume, that it might relate to this code-block not being seperated from the text by a blank line.
And even if not, approving this merge request might improve readability for those who might read this in a txt-Editor, and improve the consistency of this file.
However, if this behaviour is intended feel free to reject this merge request.
Which issue(s) this PR fixes: I didn't find an issue relating to this. As this is an minor change, it should not need a issue associated (as stated by contributing guidelines).