Skip to content

Update sectionOffset(for:) to return optional #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 18, 2021
Merged

Update sectionOffset(for:) to return optional #26

merged 2 commits into from
Jan 18, 2021

Conversation

JosephDuffy
Copy link
Member

We've discussed returning -1 not being great previously, but now we have the 2.0 branch we can make this change :)

@JosephDuffy JosephDuffy requested a review from shaps80 January 18, 2021 15:34
shaps80
shaps80 approved these changes Jan 18, 2021
View reviewed changes
Copy link
Collaborator

@shaps80 shaps80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my comment on the other PR. I get it now! Actually I like this approach as its certainly more clear.

@JosephDuffy JosephDuffy merged commit 88be0eb into 2.0-beta Jan 18, 2021
@JosephDuffy JosephDuffy deleted the 2.0/return-optional-from-sectionOffset branch January 18, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaps80 shaps80 shaps80 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JosephDuffy @shaps80