Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not always load remote package info for path repository packages #10482

Closed
sveneld opened this issue Jan 25, 2022 · 7 comments
Closed

Do not always load remote package info for path repository packages #10482

sveneld opened this issue Jan 25, 2022 · 7 comments
Labels
Milestone

Comments

@sveneld
Copy link
Contributor

sveneld commented Jan 25, 2022

In this issue #9751 updating of path repository was added, but
when many developers works with same package which is configured as 'path' they get a conflict during merging their branches due to the change of reference for path package in composer.lock. Is it possible to add an config option for path packages for removing such behavior?

@Seldaek
Copy link
Member

Seldaek commented Feb 2, 2022

IMO the downsides are worse than the conflicts you may get on the reference. But one question to me is whether we could also always fix the reference to a single value when it comes from a path repo, that would probably remove the conflicts entirely. I need to think some more about this but I think it works.

@Seldaek Seldaek added this to the 2.2 milestone Feb 2, 2022
@Seldaek Seldaek added the Bug label Feb 2, 2022
@Seldaek
Copy link
Member

Seldaek commented Feb 2, 2022

On second thought, the problem really is that if you don't change the reference every time you may have an out of date path package if your path repo is copying and not symlinking.

So I am not sure what we can do at least if copying is allowed. Perhaps we could suppress the git reference if symlink:true is set in the repository options.

@Seldaek Seldaek added Feature and removed Bug labels Feb 2, 2022
@Seldaek Seldaek modified the milestones: 2.2, 2.3 Feb 2, 2022
@Seldaek
Copy link
Member

Seldaek commented Feb 2, 2022

OK abusing symlink:true is a bit of a mess after all IMO so I'd rather add a new option reference which could have a value of auto (default), none (always null, probably what you want here) and config (which is the default when no .git info is present, i.e. it hashes the composer.json and repo config, and still provides a useful reference showing when something changed in that package, which I find more useful than no ref at all).

@sveneld
Copy link
Contributor Author

sveneld commented Feb 2, 2022

#10488 I created a pull request for it

@Seldaek
Copy link
Member

Seldaek commented Feb 2, 2022

@sveneld I saw yes, could you update it to match what I described above perhaps with the different modes?

@sveneld
Copy link
Contributor Author

sveneld commented Feb 2, 2022

Ok, I will do it tomorrow

@sveneld
Copy link
Contributor Author

sveneld commented Feb 3, 2022

@Seldaek done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants