Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3.0RC1] show command output breaks #10623

Closed
llaville opened this issue Mar 16, 2022 · 2 comments
Closed

[2.3.0RC1] show command output breaks #10623

llaville opened this issue Mar 16, 2022 · 2 comments
Labels
Milestone

Comments

@llaville
Copy link

@llaville llaville commented Mar 16, 2022

Output of composer diagnose:

Checking composer.json: OK
Checking platform settings: OK
Checking git settings: OK
Checking http connectivity to packagist: OK
Checking https connectivity to packagist: OK
Checking github.com rate limit: OK
Checking disk free space: OK
Checking pubkeys:
Tags Public Key Fingerprint: 4AC45767 E5EC2265 2F0C1167 CBBB8A2B  0C708369 153E328C AD90147D AFE50952
Dev Public Key Fingerprint: 4AC45767 E5EC2265 2F0C1167 CBBB8A2B  0C708369 153E328C AD90147D AFE50952
OK
Checking composer version: You are not running the latest stable version, run `composer self-update` to update (2.3.0-RC1 => 2.2.9)
Composer version: 2.3.0-RC1
PHP version: 7.4.0 - Package overridden via config.platform, actual: 7.4.28
PHP binary path: /usr/local/bin/php
OpenSSL version: OpenSSL 1.1.1d  10 Sep 2019
cURL version: 7.64.0 libz 1.2.11 ssl OpenSSL/1.1.1d
zip: extension present, unzip present, 7-Zip not available

When I run this command:

composer show --all --format=json -vvv symfony/polyfill-iconv v1.25.0

I get the following output:

Running 2.3.0-RC1 (2022-03-16 09:25:31) with PHP 7.4.28 on Linux / 4.19.128-microsoft-standard
Reading ./composer.json (/shared/backups/bartlett/php-compatinfo-db/composer.json)
Loading config file ./composer.json (/shared/backups/bartlett/php-compatinfo-db/composer.json)
Checked CA file /etc/pki/tls/certs/ca-bundle.crt does not exist or it is not a file.
Checked directory /etc/pki/tls/certs/ca-bundle.crt does not exist or it is not a directory.
Checked CA file /etc/ssl/certs/ca-certificates.crt: valid
Executing command (/shared/backups/bartlett/php-compatinfo-db): 'git' 'branch' '-a' '--no-color' '--no-abbrev' '-v'
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list master..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list 4.x..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list 4.0..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list 3.16..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list remotes/origin/master..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list remotes/origin/4.x..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list remotes/origin/4.0..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list remotes/origin/3.19..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list remotes/origin/3.16..polyfill
Failed to initialize global composer: Composer could not find the config file: /home/devilbox/.composer/composer.json

Reading /shared/backups/bartlett/php-compatinfo-db/vendor/composer/installed.json
Loading plugin cweagans\Composer\Patches (from cweagans/composer-patches)
Reading ./composer.lock (/shared/backups/bartlett/php-compatinfo-db/composer.lock)
Reading /home/devilbox/.composer/cache/repo/https---repo.packagist.org/packages.json from cache
Downloading https://repo.packagist.org/packages.json if modified
[304] https://repo.packagist.org/packages.json
Downloading https://packagist.org/packages/list.json?filter=symfony%2Fpolyfill-iconv
[200] https://packagist.org/packages/list.json?filter=symfony%2Fpolyfill-iconv
{
    "available": [
        {
            "name": "symfony/polyfill-iconv"
        }
    ]
}

And I expected this to happen: Same output got with compose 2.2

Running 2.2.6 (2022-02-04 17:00:38) with PHP 7.4.28 on Linux / 4.19.128-microsoft-standard
Reading ./composer.json (/shared/backups/bartlett/php-compatinfo-db/composer.json)
Loading config file ./composer.json (/shared/backups/bartlett/php-compatinfo-db/composer.json)
Checked CA file /etc/pki/tls/certs/ca-bundle.crt does not exist or it is not a file.
Checked directory /etc/pki/tls/certs/ca-bundle.crt does not exist or it is not a directory.
Checked CA file /etc/ssl/certs/ca-certificates.crt: valid
Executing command (/shared/backups/bartlett/php-compatinfo-db): git branch -a --no-color --no-abbrev -v
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list master..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list 4.x..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list 4.0..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list 3.16..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list remotes/origin/master..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list remotes/origin/4.x..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list remotes/origin/4.0..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list remotes/origin/3.19..polyfill
Executing command (/shared/backups/bartlett/php-compatinfo-db): git rev-list remotes/origin/3.16..polyfill
Failed to initialize global composer: Composer could not find the config file: /home/devilbox/.composer/composer.json

Reading /shared/backups/bartlett/php-compatinfo-db/vendor/composer/installed.json
Loading plugin cweagans\Composer\Patches (from cweagans/composer-patches)
Reading ./composer.lock (/shared/backups/bartlett/php-compatinfo-db/composer.lock)
Reading /home/devilbox/.composer/cache/repo/https---repo.packagist.org/packages.json from cache
Downloading https://repo.packagist.org/packages.json if modified
[304] https://repo.packagist.org/packages.json
Reading /home/devilbox/.composer/cache/repo/https---repo.packagist.org/provider-symfony~polyfill-iconv.json from cache
Downloading https://repo.packagist.org/p2/symfony/polyfill-iconv.json if modified
Reading /home/devilbox/.composer/cache/repo/https---repo.packagist.org/provider-symfony~polyfill-iconv~dev.json from cache
Downloading https://repo.packagist.org/p2/symfony/polyfill-iconv~dev.json if modified
[304] https://repo.packagist.org/p2/symfony/polyfill-iconv.json
[304] https://repo.packagist.org/p2/symfony/polyfill-iconv~dev.json
{
    "name": "symfony/polyfill-iconv",
    "description": "Symfony polyfill for the Iconv extension",
    "keywords": [
        "iconv",
        "compatibility",
        "portable",
        "polyfill",
        "shim"
    ],
    "type": "library",
    "homepage": "https://symfony.com",
    "names": [
        "symfony/polyfill-iconv",
        "ext-iconv"
    ],
    "versions": [
        "v1.25.0"
    ],
    "licenses": [
        {
            "name": "MIT License",
            "osi": "MIT",
            "url": "https://spdx.org/licenses/MIT.html#licenseText"
        }
    ],
    "source": {
        "type": "git",
        "url": "https://github.com/symfony/polyfill-iconv.git",
        "reference": "f1aed619e28cb077fc83fac8c4c0383578356e40"
    },
    "dist": {
        "type": "zip",
        "url": "https://api.github.com/repos/symfony/polyfill-iconv/zipball/f1aed619e28cb077fc83fac8c4c0383578356e40",
        "reference": "f1aed619e28cb077fc83fac8c4c0383578356e40"
    },
    "suggests": {
        "ext-iconv": "For best performance"
    },
    "support": {
        "source": "https://github.com/symfony/polyfill-iconv/tree/v1.25.0"
    },
    "autoload": {
        "psr-4": {
            "Symfony\\Polyfill\\Iconv\\": "."
        }
    },
    "requires": {
        "php": ">=7.1"
    },
    "provides": {
        "ext-iconv": "*"
    }
}
@llaville
Copy link
Author

@llaville llaville commented Mar 16, 2022

This is related to JSON format, console too gave same output changes

Compare Composer 2.2

name     : symfony/polyfill-iconv
descrip. : Symfony polyfill for the Iconv extension
keywords : iconv, compatibility, portable, polyfill, shim
versions : v1.25.0
type     : library
license  : MIT License (MIT) (OSI approved) https://spdx.org/licenses/MIT.html#licenseText
homepage : https://symfony.com
source   : [git] https://github.com/symfony/polyfill-iconv.git f1aed619e28cb077fc83fac8c4c0383578356e40
dist     : [zip] https://api.github.com/repos/symfony/polyfill-iconv/zipball/f1aed619e28cb077fc83fac8c4c0383578356e40 f1aed619e28cb077fc83fac8c4c0383578356e40
names    : symfony/polyfill-iconv, ext-iconv

support
source : https://github.com/symfony/polyfill-iconv/tree/v1.25.0

autoload
files
psr-4
Symfony\Polyfill\Iconv\ => .

requires
php >=7.1

suggests
ext-iconv For best performance

provides
ext-iconv *

Against Composer 2.3

available:
  symfony/polyfill-iconv

@llaville llaville changed the title [2.3.0RC1] show command JSON-formatted output breaks [2.3.0RC1] show command output breaks Mar 16, 2022
@Seldaek Seldaek added this to the 2.3 milestone Mar 16, 2022
@Seldaek Seldaek added the Bug label Mar 16, 2022
@Seldaek
Copy link
Member

@Seldaek Seldaek commented Mar 16, 2022

Thanks for the report, it was a silly boolean inversion mistake when I switched from strpos() to str_contains 🤦🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants