Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Fail when COMPOSER_AUTH is malformed #11085

Closed
aurelijusrozenas opened this issue Sep 27, 2022 · 1 comment
Closed

[FEATURE REQUEST] Fail when COMPOSER_AUTH is malformed #11085

aurelijusrozenas opened this issue Sep 27, 2022 · 1 comment
Labels
Milestone

Comments

@aurelijusrozenas
Copy link

Hi,

There have been multiple when I stepped on this rake and got hit in the face: composer install does not work for private repos. And then I go debugging ssh connections, deployer scripts, docker configuration etc. only to find somewhere in the logs:

COMPOSER_AUTH environment variable is malformed, should be a valid JSON object

And then everything is obvious and the fix is around the corner.

This time I am thinking maybe there is a better way? One solution could be to make composer install (or maybe all composer commands?) to fail when COMPOSER_AUTH is malformed? O maybe add parameter to make it fail?
It would be nice if this never happens to me or my colleague again. If COMPOSER_AUTH is set, it should valid otherwise what's the point of setting it, right?

What do you think? 👨‍🎤

@Seldaek
Copy link
Member

Seldaek commented Oct 12, 2022

Yes I can see if you set it you'd not want it to have it be ignored.. Scheduling for 2.5 tho as it could kinda come as a surprise to people in a patch release.

@Seldaek Seldaek added this to the 2.5 milestone Oct 12, 2022
emahorvat52 pushed a commit to emahorvat52/composer that referenced this issue Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants