-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPORTANT] Platform check is causing to broke websites with unfair way #11091
Comments
If you need to stay compatible with ancient versions of PHP (no judgement here), I'd strongly recommend to use Composer 2.2 instead. It's an LTS version that is still maintained to accomodate projects like yours. The world has moved on and this version check that troubles you right now indicates that the authors of Composer cannot guarantee anymore that the generated autoloader code will be compatible with the PHP version your project is running on. |
@derrabus it would still be a good idea to build it on the same reporting way than the platform checks, which were designed to break in a good way (reporting a 500 error and not a 200 error) |
@derrabus Dropping support of legacy is OK. This issue is only HOW is dropping implemented. |
Sorry about that. Hopefully resolved by c447c12 - tho it'll still kill websites, just in a nicer way. I guess this is due to shared hosts upgrading things automatically without checking compatibility at all? |
Yes, it's what I ask. The fair kill. Thanks. Upgrades are maked automatically by lot of (semi-)automated app hosting, like a clouds and similar one. The problem lies in the detail, here can be not any change in runtime (PHP version, server, atc.), neither app itself, but can be upgraded build tool only (Composer) which is not presented to production. Only modicum od developer expects trap here wen nothich in APP nor Runtime changed. |
Composer from version 2.3.0 can be application runtime afflicted by unpredicted Composer's platform check.
composer/src/Composer/Autoload/AutoloadGenerator.php
Lines 888 to 894 in 5770fb0
It is understandable and justified, but completely poorly implemented. This is same problem as I reported formerly at #9411 and fixed at #9410, #9414 and #9418.
Problems:
200 OK
status code. This can ruin SEO reputation!It's now shutdowns websites across the world.
Trust me its't very serious problem, try to search
-echo "Composer 2.3.0 dropped support for autoloading on PHP <5.6 and you are running"
for proof.Please fix that with same way as another platform check (see above to previous PR references):
composer/src/Composer/Autoload/AutoloadGenerator.php
Lines 849 to 868 in 5770fb0
Please be always very very careful when you adding any check/error message which is fired at autoload runtime! Composer have enormous power, they should also have enormous responsibility.
The text was updated successfully, but these errors were encountered: