(possibly) update RootPackageLoaderTest

[xrstf]

Inside the RootPackageLoaderTest, the issue sebastianbergmann/phpunit-mock-objects#81 has been referenced:

Can do away with this mock object when sebastianbergmann/phpunit-mock-objects#81 is fixed

The issue has been closed 8 days ago, so maybe the test can be cleaned up.

[stof]

but this is not yet part of a released version of the library, right ?

[xrstf]

It looks like v1.2.3 was released one day after merging the fix: https://github.com/sebastianbergmann/phpunit-mock-objects/commits/1.2.3

[stof]

Ok, so it is fixed when using PHPUnit 3.7.13. Maybe we should wait until Travis uses this version ?

[xrstf]

No need to rush, I just wanted to post a little reminder because I was poking around the Composer source ;-)

[simensen]

I took a look at this today with PHPUnit 3.7.22 and I don't see that this is working. I could be totally wrong on how this was intended to work, though? I tried:

<?php
        $processExecutor = $this->getMockBuilder('\\Composer\\Util\\ProcessExecutor')
            ->disableOriginalConstructor()
            ->getMock();

        $self = $this;

        $processExecutor
            ->expects($this->once())
            ->method('execute')
            ->will($this->returnCallback(function ($command, &$output = null, $cwd = null) use ($commitHash, $self) {
                $self->assertStringStartsWith('git branch', $command);

                $output = "* (no branch) $commitHash Commit message\n";

                return 0;
            }));

I get:

Invalid argument supplied for foreach()

So the output is not being set correctly.

Based on the notes for PHPUnit 3.7 it looks like cloning the params should be off by default. I tried both enableArgumentCloning and disableArgumentCloning and it seemed to make no difference. Did sebastianbergmann/phpunit-mock-objects#81 actually address a different problem?

[alcohol]

@stof is this still applicable?