Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"API" for install path #2174

Closed
gossi opened this issue Aug 14, 2013 · 7 comments
Closed

"API" for install path #2174

gossi opened this issue Aug 14, 2013 · 7 comments

Comments

@gossi
Copy link

@gossi gossi commented Aug 14, 2013

Disclaimer: This issue is not intended for an end-users. Instead it focuses on tooling support for composer (such as the Composer-Eclipse-Plugin)

When packages installed, they are typically installed in the vendor directory. Though especially custom-installers change the path. One of the main features of the Eclipse-Composer-Plugin is to automatically manage the build-path, so that code-assist works seamlessly without any further user-interaction. For now, packages installed with a custom install path can't be automatically managed.

For these cases an install path "API" (maybe be another property in one of the json-files) would be handy and welcome to provide tooling support.

Thanks
gossi

@Seldaek
Copy link
Member

@Seldaek Seldaek commented Aug 14, 2013

This could probably be dumped in vendor/composer in a new file or as part of the installed.json.. anyway I may not have time for this in a while because it's not critical, but if you'd like to do it I'm not against it.

@hason
Copy link
Contributor

@hason hason commented Aug 14, 2013

About a week ago I did something similar. I'll create a PR.

@Seldaek
Copy link
Member

@Seldaek Seldaek commented Apr 29, 2015

Is this still relevant? I am thinking if we got by without for so long it might be unnecessary complexity.

@gossi
Copy link
Author

@gossi gossi commented Apr 29, 2015

It still is, can't implement until this thing is done.

@Seldaek
Copy link
Member

@Seldaek Seldaek commented Apr 29, 2015

Have you looked at @hason's PR and perhaps tried it?

@gossi
Copy link
Author

@gossi gossi commented May 2, 2015

Actually, I only have noticed his PR... See my question there.

Seldaek added a commit that referenced this issue Aug 2, 2019
…closes #2424
@Seldaek
Copy link
Member

@Seldaek Seldaek commented Aug 2, 2019

In composer v2, install-path will be present on every package entry in installed.json

@Seldaek Seldaek closed this Aug 2, 2019
naderman added a commit to naderman/composer that referenced this issue Sep 7, 2019
…-installed

* github-composer/2.0: (48 commits)
  Fix missing use/undefined var
  Split up steps on VCS downloaders to allow doing network operations before touching the filesystem on GitDownloader, fixes composer#7903
  Fix use statement
  Deduplicate findHeaderValue code
  Add install-path to the installed.json for every package, fixes composer#2174, closes composer#2424
  Remove unnecessary config from phpstan
  Make sure the directory exists and will not block installation later when downloading
  Avoid wiping the whole target package if download of the new one fails, refs composer#7929
  Only empty dir before actually installing packages, fixes composer#7929
  Improve output when installing packages
  Show best possible version in diagnose command
  Remove extra arg
  Allow path repos to point to their own source dir as install target, resulting in noop, fixes composer#8254
  Fix use of decodeJson
  Fix update mirrors to also update transport-options, fixes composer#7672
  Fix updating or URLs to include dist type and shasum, fixes composer#8216
  Fix origin computation
  Improve handling of non-standard ports for GitLab and GitHub installs, fixes composer#8173
  Load packages from the lock file for check-platform-reqs if no dependencies have been installed yet, fixes composer#8058
  Fix error_handler return type declaration
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants