Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving VersionParser/Constraint related classes to separate library #2523

Closed
schmittjoh opened this issue Dec 22, 2013 · 5 comments
Closed
Labels
Milestone

Comments

@schmittjoh
Copy link
Contributor

Version parsing & comparison seems very useful outside of composer. It would be cool to have the related classes in a small, dedicated library.

@Seldaek
Copy link
Member

Seldaek commented Dec 26, 2013

It's kinda hard because it is partly intertwined with composer specific code. It's not impossible of course, but not sure how useful it is all in a non-composer context compared to just using version_compare. And for the composer context you can already use composer/composer as a lib.

So I'm not against it per se but just wondering if it's worth the time.

@staabm
Copy link
Contributor

staabm commented Dec 26, 2013

Maybe @schmittjoh could elaborate a bit more how he would use this lib outside of composer?

@schmittjoh
Copy link
Contributor Author

I had looked for a way to parse a composer constraint and check whether it
satisfies a given version, i.e. given the constraint ">=5.4", I'd like to
check whether it would be satisfied by "5.4" or "5.5" etc.

Ideally, one could re-use composer's own parsing/comparison routines and I
guess this is already possible with using composer/composer as a dependency
as @Seldaek suggested. Having a small library would be nice though.

On Thu, Dec 26, 2013 at 7:18 PM, Markus Staab notifications@github.comwrote:

Maybe @schmittjoh https://github.com/schmittjoh could elaborate a bit
more how he would use this lib outside of composer?


Reply to this email directly or view it on GitHubhttps://github.com//issues/2523#issuecomment-31230012
.

@legoktm
Copy link
Contributor

legoktm commented May 21, 2015

Dupe of #3545?

@Seldaek
Copy link
Member

Seldaek commented Feb 16, 2016

It's in composer/semver now

@Seldaek Seldaek closed this as completed Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants