ArchivableFilesFinder / GitExcludeFilter

[kryptychon]

Hi there,

I'm running a private package repository with satis and git.

While rebuilding the packages, I noticed, some packages are not containing all the files I get doing "git clone /foo/bar".
I did some research ending up in

composer/src/Composer/Package/Archiver/ArchivableFilesFinder.php

Line 48 in 1d8f05f

new GitExcludeFilter($sources),

The cause for the "missing stuff" in the packages is the GitExcludeFilter, parsing the .gitignore files and preventing the ignored stuff to show up in the packages.

Is there a way to prevent this behavior e.g with an option during the satis build process?

Regards,
Kryp

[cs278]

You have files added in your repository that are mentioned in your gitignore file? You could fix your ignore file so it makes sense.

Composer shouldn't be consulting the ignore file for archives though.

Edit: words

[cs278]

@naderman Was there any reason to deviate from Git's behaviour in #1567?

[naderman]

I don't remember that to be honest. From today's perspective I would say it should respect gitattributes but gitignore should have no impact on generating archives.

[cs278]

@naderman It has occurred to me that it might be to try and account for a dirty repository. Perhaps it would be safer to abort if git status --ignored is not empty.

[kryptychon]

Hi,

maybe I'm missing something.
Why is satis trying to be "intelligent" by parsing the .gitignore stuff?
Isn't that the part of git itself when comitting?

In my judgment, satis should build packages from what it checks out from the git repository.

[kryptychon]

Further investigation turnes out, the .gitignore is not properly parsed.
Any progress on that issue?

[Seldaek]

Can you give details as to why/how it is not properly parsed? Otherwise there is no chance anyone can fix this.

[marcaube]

I've hit the same problem with a package that I don't own.

$ composer archive leafo/scssphp 0.0.7
Searching for the specified package.
Found an exact match leafo/scssphp v0.0.7.
Creating the archive into ".".
  - Installing leafo/scssphp (v0.0.7)
    Downloading: 100%         

Created: ./leafo-scssphp-e5a79218c349cbc03dc99004fbad938c7b82391f-zip-0db3e8.tar

Open the archive and the file scss.inc.php is missing. If you check in the GitHub archive, scss.inc.php is present. This mismatch is problematic as we have to leave that one single dependency outside of Satis, rendering the whole exercise pointless. If GitHub goes down, we go down too.

[Seldaek]

@marcaube Toran Proxy does not have that issue AFAIK as it uses the zip files from github when available. Maybe consider switching over?