Commit 3efed220 breaks existing ScriptHandlers

[uwej711]

The mentioned commit changes the event from CommandEvent to Event for ScriptHandlers, which breaks my own handlers and also those of SensioDistributionBundle. You get this if you do a simple composer self-update.

Is this intentionally?

[stevelacey]

Just needs to be in a message not a title, boom 3efed22

[alcohol]

https://github.com/composer/composer/blob/master/src/Composer/Script/CommandEvent.php#L18

[uwej711]

Anyway, this makes it impossible to use composer with older ScriptHandlers

[alcohol]

That's ok, composer is still an alpha, incompatible changes will happen. Upgrade your scripthandlers.

I don't entirely see the problem by the way, CommandEvent extends from Event, so both are still ok.

Also, for BC: https://github.com/composer/composer/blob/master/src/Composer/EventDispatcher/EventDispatcher.php#L222

So what exactly is broken now for you? Can you actually provide a reproducible scenario, other than some comment without context?

[Seldaek]

I think it only breaks if you had incorrect (too loose?) type hints. For most people the BC layer worked, in a few cases yes there is breakage and I am sorry but I think updating and releasing a new version of those few script handlers is probably not so hard. On the other hand we had a huge mess here so it had to be cleaned up.

[uwej711]

Im affected as a user of SensioDistributionBundle. Will there be an update?

[alcohol]

Check with them?

[uwej711]

I conclude this was intentionally and there is currently no way to resolve this other than stopping updating composer for a while.

[alcohol]

Because asking the maintainer of the broken package to fix it is not an option..? Ok..

[uwej711]

Well no, that is not the problem. But as you said, it needs to be fixed there. So closing this.

[alcohol]

Though https://github.com/sensiolabs/SensioDistributionBundle/blob/master/Composer/ScriptHandler.php to me looks to be using proper typehints, so the BC layer provides for that. I see no reason why SensioDistributionBundle would not work.

[uwej711]

@alcohol you are right, thanks for pointing me to the right direction. The mistake was in our own code not using type hints for the events at all. Please accept my apologies.

Uwe