Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthHelper askAndValidate Always Causes exception #3987

Closed
daum opened this issue Apr 30, 2015 · 3 comments
Closed

AuthHelper askAndValidate Always Causes exception #3987

daum opened this issue Apr 30, 2015 · 3 comments

Comments

@daum
Copy link
Contributor

daum commented Apr 30, 2015

In AuthHelper where it asks if you want to store the credentials (https://github.com/composer/composer/blob/master/src/Composer/Util/AuthHelper.php#L39) it passes through "false" for the third option to the IO helper (https://github.com/composer/composer/blob/master/src/Composer/IO/ConsoleIO.php#L247) to pass it as a false to the Symfony\Component\Console\Question\Question class which results in an InvalidArgumentException being thrown as seen here: https://github.com/symfony/Console/blob/master/Question/Question.php#L194

This means any time that the helper asks that question it will cause an exception to be caused, breaking any install/update that is currently being run. Will make PR momentarily.

@alcohol
Copy link
Member

alcohol commented May 1, 2015

My bad. I'll give the whole src another thorough look for calls to askAndValidate.

@alcohol
Copy link
Member

alcohol commented May 1, 2015

Never mind, seems that was the only one I missed. Thanks.

@Seldaek please merge asap. Sorry for the inconvenience.

@Seldaek
Copy link
Member

Seldaek commented May 1, 2015

Thanks @daum!

@Seldaek Seldaek closed this as completed May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants