Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Relative Path File Collection #8035
I'm working on an interesting issue when using the
I've noted the patching library uses
$this->remoteFileSystem being the RemoteFilesystem instance.
As not everyone will be changing the vendor path, I can't specify different paths in the patch library composer.json e.g:
I've got two options:
So my question is would it be possible for composer to automatically translate requests for files starting 'vendor/' to use the COMPOSER_VENDOR_DIR environment variable when requesting local filesystem file content?
Any other solutions or recommendations more than welcome
@alcohol Cheers for the review!
I did see a lot of mapping for hosts and other logic in there and wondered if it would be a useful addition, looking at it from a composer point of view, it deals with the paths fine and shouldn't need any mappings in the download/getContents method.
So the correct solution would be the library/plugin correctly resolving the vendor path, e.g: https://github.com/netresearch/composer-patches-plugin/pull/30/files
Just wanted to make sure the change was applied to the best possible place