Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change breaks support for older git-versions #8598

Closed
tomasnorre opened this issue Feb 12, 2020 · 6 comments
Closed

Change breaks support for older git-versions #8598

tomasnorre opened this issue Feb 12, 2020 · 6 comments

Comments

@tomasnorre
Copy link

@tomasnorre tomasnorre commented Feb 12, 2020

This commit:
0bd3f27

Breaks compatibility with older git versions.

I don't know in which version from git the -c parameter got introduced, Would expect in 2.0.0, it isn't in 1.7.1 which lead me to the breaking change.

Getting following error on composer install --dry-run,
verbose says that no valid composer.json is found, but composer validate doesn't report anything

Skipped branch master, DateTime::__construct(): Failed to parse time string (@) at position 0 (@): Unexpected character

Summery:
https://twitter.com/tomasnorre/status/1227538070154686469

@tomasnorre tomasnorre changed the title Breaking Changes breaks support for older git-versions Change breaks support for older git-versions Feb 12, 2020
@alcohol

This comment has been minimized.

Copy link
Member

@alcohol alcohol commented Feb 12, 2020

So update your install of git. You're several (nearly 10) years behind already.

@alcohol alcohol closed this Feb 12, 2020
@tomasnorre

This comment has been minimized.

Copy link
Author

@tomasnorre tomasnorre commented Feb 12, 2020

I sort of agree, but it's still breaking ;) and not all systems are easy to update.
Cannot risk destroying my build server.

But have reverted my composer version for now, and then I'll check if updating git is possible.

@alcohol

This comment has been minimized.

Copy link
Member

@alcohol alcohol commented Feb 12, 2020

I understand that some legacy systems are hard to maintain and are barely kept up to date.

When it comes to external tooling, we kind of just go with what seems reasonable. Perhaps we can document somewhere what the minimum required versions are. But it's hard to keep track and even harder to get users to actually pay attention to it, so I'm not sure if that effort is even worth it.

You pretty much only need git if you have dependencies that are unversioned or sources which don't offer dist files (e.g. private non-github git repositories). Because for everything else, we can just use zipfiles.

@tomasnorre

This comment has been minimized.

Copy link
Author

@tomasnorre tomasnorre commented Feb 13, 2020

I know, I also don't what to argue with you, I'm totally on you side.

Was just surprised that my setup al the sudden broke.
But the problem is for sure more mine than yours.

Just hoped there was an easy fix, to get this supported.

And to be honest, didn't know my git was that old.

@alcohol

This comment has been minimized.

Copy link
Member

@alcohol alcohol commented Feb 13, 2020

Yeah no worries at all, I did not perceive your response as arguing.

If you can manage to get a Docker daemon running on your build server, you could solve a whole lot of your tooling issues as it is much easier to support different versions using different containers.

@tomasnorre

This comment has been minimized.

Copy link
Author

@tomasnorre tomasnorre commented Feb 14, 2020

I'm trying to get rid of the Build server, so will try to lowest effort to get it running and atm. it's switching to an older composer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.