New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git::checkRefIsInMirror prevents https/git public usage #8932
Comments
btw, doing git clone https://github.com/beberlei/env.git ../testext in the console work just fine. So it could be some operations called in this method that requires now auth |
Found the culprit. HOME env is not defined. ` - Installing env (master): PHP Notice: Undefined index: home in /home/pierre/projects/php/pickle/pickle/vendor/composer/composer/src/Composer/Config.php on line 279 Notice: Undefined index: home in /home/pierre/projects/php/pickle/pickle/vendor/composer/composer/src/Composer/Config.php on line 279 So another issue, minor, but the notice should not happen. @Seldaek What behavior do you expect if HOME is missing? I can provide a PR |
2nd issue is why HOME is missing or does not make it at this stage inside composer. As it is defined and available before the call to GitDownloader. |
Any change regarding COMPOSER_HOME behavior when not set? It seems it was defaulting to ~/.config/composer before but latest do not, leading to the unset config HOME. |
Not sure what this is all about, but composer/src/Composer/Factory.php Line 164 in 662d6d8
As for HOME env var, which is something else, it needs to be defined or COMPOSER_HOME needs to be defined, as per composer/src/Composer/Factory.php Line 56 in 662d6d8
I guess you figured it out somehow tho, but I'd suggest perhaps switching to Composer\Factory still. Can this be closed otherwise? |
I use the later to fix it, including the COMPOSER_HOME check. It looks, if I understand you correctly, like it should rely on Factory::createConfig only to be clean. I will update the code accordingly. Thanks! |
Using GitDowloader with the following config:
I now get (just updated to latest stable composer release):
This is something that was not before. The git error happens in the Git::checkRefIsInMirror. Basically it seems it is not allowed for public repo anymore or something is wrong elsewhere.
Any thoughts?
You can see the usage here: https://github.com/FriendsOfPHP/pickle/blob/master/src/Package/Convey/Command/Git.php#L59
Or do you suggest an alternative way to use the download for any Git repo (public or not)?
The text was updated successfully, but these errors were encountered: