Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplFileInfo: getRealPath can return false in ArchivableFilesFinder #10665

Merged
merged 1 commit into from Mar 29, 2022

Conversation

glaubinix
Copy link
Contributor

@glaubinix glaubinix commented Mar 28, 2022

Fixes: TypeError(code: 0): strpos(): Argument #1 ($haystack) must be of type string, bool given at src/Composer/Package/Archiver/ArchivableFilesFinder.php:61

Happens for instance if files in the bin folder are pointing to the vendor directory and vendors are not installed

@glaubinix glaubinix marked this pull request as draft Mar 28, 2022
@glaubinix glaubinix marked this pull request as ready for review Mar 28, 2022
@Seldaek Seldaek added this to the 2.3 milestone Mar 29, 2022
@Seldaek Seldaek added the Bug label Mar 29, 2022
@Seldaek Seldaek merged commit 1fff47b into composer:main Mar 29, 2022
16 of 17 checks passed
@Seldaek
Copy link
Member

@Seldaek Seldaek commented Mar 29, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants