Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitDriver: try to fetch default branch form remote using auth #10701

Merged
merged 1 commit into from Apr 13, 2022

Conversation

glaubinix
Copy link
Contributor

@glaubinix glaubinix commented Apr 4, 2022

Building on top of #10687

Just running git remote show origin works fine if authentication is set up via public/private key. Fetching the data from a remote that requires username/password authentication requires updating the remote URL first.

This also exposed the command output of Git:: runCommand which previously was just ignore because not necessary anywhere.

@glaubinix glaubinix force-pushed the f/git-remote-default-branch branch from 86651bd to cbc750a Compare Apr 4, 2022
@Seldaek Seldaek merged commit 866d2a4 into composer:main Apr 13, 2022
15 of 17 checks passed
@Seldaek Seldaek added this to the 2.3 milestone Apr 13, 2022
@Seldaek Seldaek added the Bug label Apr 13, 2022
@Seldaek
Copy link
Member

@Seldaek Seldaek commented Apr 13, 2022

Thanks

@glaubinix glaubinix deleted the f/git-remote-default-branch branch Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants