Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the ability to list the scripts in the 'run-script' command without providing a script #10710

Merged
merged 1 commit into from Apr 7, 2022

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Apr 5, 2022

Fixes #10705
Fixes #10707

After #10476 the ability to list scripts from the run-script command without passing a script name (i.e. composer run-script -l) was lost because the script argument was made required. This restores the ability to list the scripts without needing to pass something to fill the script argument while also failing if not listing scripts and a script name wasn't provided.

stof
stof approved these changes Apr 6, 2022
@mbabker mbabker changed the title Restore the ability to list the scripts in the 'run-script' command Restore the ability to list the scripts in the 'run-script' command without providing a script Apr 6, 2022
@Seldaek
Copy link
Member

@Seldaek Seldaek commented Apr 7, 2022

Thanks for the test updates, that looks pretty good already!

I should be able to build up some utilities to shorten the test bootstrap a bit further and then we have something really usable to improve the coverage of all our command code (which sits somewhere close to 0% right now).

And thanks for the fix :)

@Seldaek Seldaek merged commit 58e1351 into composer:main Apr 7, 2022
16 of 17 checks passed
@Seldaek Seldaek added this to the 2.3 milestone Apr 7, 2022
@Seldaek Seldaek added the Bug label Apr 7, 2022
@mbabker mbabker deleted the restore-list-scripts branch Apr 7, 2022
coudenysj added a commit to coudenysj/heroku-buildpack-php that referenced this issue Apr 8, 2022
Fixes regression in Composer script listing (composer/composer#10710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants