Add download-only mode #11041
Add download-only mode #11041
Conversation
|
One thing left to consider fixing is this leaves the |
Jellyfrog
force-pushed
the
feature/download-only
branch
from
c4517bc
to
c10b5d4
Compare
|
It now cleans the tmp files. |
Jellyfrog
force-pushed
the
feature/download-only
branch
from
5460a6d
to
75db49b
Compare
Jellyfrog
force-pushed
the
feature/download-only
branch
from
75db49b
to
91b6a1b
Compare
src/Composer/Installer.php
Outdated
| $this->runScripts = false; | ||
| $this->writeLock = false; | ||
| $this->dumpAutoloader = false; |
There was a problem hiding this comment.
I'm not so sure about thse..
Removing autoload dumping sure, makes sense.
Disabling scripts I think that is a mistake as plugins and whatever might depend on those scripts to do the downloading correctly.
And writeLock I think I would leave it on, as if you do an update with download only (not possible via CLI, but possible if you do this programmatically) it should still persist the update result to the lock file IMO.
| if ($downloadOnly) { | ||
| $this->download($package); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I have a gut feeling this isn't the best way to bypass the operations here.. But I gotta try it myself, if I can improve I'll add a commit to your branch.
…but reuse existing cleanup promises, and avoid writing the installed repo
|
Thanks! |
composer install --download-only to prime the cache/download archives but not do any actual of the actual installing Fixes composer#11035 Co-authored-by: Jordi Boggiano <j.boggiano@seld.be>
Fixes #11035