Feature: Add support for autocompleting setting-keys in config-command #11130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements the support for autocompletion of setting-keys in the config-command and its related funtional tests. The implementation takes existing command-line options like `--unset` or `--global` into account, as well as existing exposable package-properties. The result is a context- sensitive auto-completion of individual lists of setting-keys. Additionally showing the value `suggest.` sub-keys has been allowed in the config-command, as setting and unsetting them has alwas been possible, and I did not want to distinguish between showing, setting and unsetting those keys. In the setting-key flattening-method I used the `array_is_list()` function, which was added in PHP 8.1 recently. For backwards PHP-compatiblity the package `symfony/polyfill-php81` has been added. Signed-off-by: Stephan Jorek <stephan.jorek@brandung.de>
composer.lockPackage changes
Settings · Docs · Powered by Private Packagist |
|
Thanks, looking good! |
Thank you! |
emahorvat52
pushed a commit
to emahorvat52/composer
that referenced
this pull request
Feb 3, 2023
composer#11130) * Add support for autocompleting setting-keys in config-command This PR implements the support for autocompletion of setting-keys in the config-command and its related funtional tests. The implementation takes existing command-line options like `--unset` or `--global` into account, as well as existing exposable package-properties. The result is a context- sensitive auto-completion of individual lists of setting-keys. Additionally showing the value `suggest.` sub-keys has been allowed in the config-command, as setting and unsetting them has alwas been possible, and I did not want to distinguish between showing, setting and unsetting those keys. In the setting-key flattening-method I used the `array_is_list()` function, which was added in PHP 8.1 recently. For backwards PHP-compatiblity the package `symfony/polyfill-php81` has been added. Signed-off-by: Stephan Jorek <stephan.jorek@brandung.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the support for autocompletion of setting-keys in the config-command and its related functional tests. The implementation takes existing command-line options like
--unsetor--globalinto account, as well as existing exposable package-properties. The result is a context-sensitive auto-completion with individual lists of setting-keys.Additionally showing the value of
suggest.sub-keys has been allowed in the config-command, as setting and unsetting them has always been possible, and I did not want to distinguish between showing, setting and unsetting those keys.In the setting-key flattening-method I used the
array_is_list()function, which was added in PHP 8.1 recently. For backwards PHP-compatibility the packagesymfony/polyfill-php81has been added and the corresponding test-fixtures have been fixed accordingly.Fixes: #11131
Signed-off-by: Stephan Jorek stephan.jorek@brandung.de