Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adding Command classes as scripts, #11151

Merged
merged 7 commits into from
Oct 28, 2022

Conversation

Seldaek
Copy link
Member

@Seldaek Seldaek commented Oct 26, 2022

Fixes #11134

@Seldaek Seldaek marked this pull request as ready for review October 27, 2022 11:35
@Seldaek Seldaek added this to the 2.5 milestone Oct 27, 2022
@Seldaek Seldaek merged commit 6e55cb3 into composer:main Oct 28, 2022
@Seldaek Seldaek deleted the script_commands branch November 2, 2022 16:20
emahorvat52 pushed a commit to emahorvat52/composer that referenced this pull request Feb 3, 2023
* Add support for adding Command classes as scripts, fixes composer#11134

* Allow all options to be forwarded and allow using references to other scripts with args

* Fix build

* Add more checks

* Ensure exceptions are not swallowed, and remove naming restriction by using a single-command app

* Update docs

* Add tests, fix issue merging params when combining nested scripts and CLI params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: integrate custom, complete Symfony Console scripts
2 participants