-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check missing required packages when running install and fail when there are any #11195
Check missing required packages when running install and fail when there are any #11195
Conversation
Implementation looks reasonable and good to me, thanks! |
FYI this change broke some Renovate Bot users, I have created an issue: #11232 |
We have a scenario which breaks with this new check: we have a composer script that modifies versions when we are on a However, during deploy we run Are we just doing something that is not supported or should there be a way to allow this? |
@nickygerritsen that sounds like an edge case that we don't necessarily want to cover, but maybe we can help figure out a solution. I'd suggest you open a new issue tho to avoid spamming everyone here, and please add a bit more details as to what you do, I don't yet exactly understand the develop/main/1.0.0 and where they fit in your workflow. |
…nd fail when there are any (composer#11195)
In #9899 a check was added to the validate command to check if there are any required packages that are not locked. According to the discussion in #11154, the install command should also fail on this state. It doesn't seem there is currently any code present in the Installer that checks this, so I am adding it in this PR.
There are two things in here that I am not sure about: