Allow underscores in cache keys to avoid conflicts with package names containing underscore vs dashes #11229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… containing underscore vs dashes, fixes composer#11224
|
Thank you! Confirming that the issue has been resolved with this PR. |
stof
reviewed
Dec 19, 2022
| @@ -175,7 +175,7 @@ public function __construct(array $repoConfig, IOInterface $io, Config $config, | |||
| assert($baseUrl !== ''); | |||
| $this->baseUrl = $baseUrl; | |||
| $this->io = $io; | |||
| $this->cache = new Cache($io, $config->get('cache-repo-dir').'/'.Preg::replace('{[^a-z0-9.]}i', '-', Url::sanitize($this->url)), 'a-z0-9.$~'); | |||
| $this->cache = new Cache($io, $config->get('cache-repo-dir').'/'.Preg::replace('{[^a-z0-9.]}i', '-', Url::sanitize($this->url)), 'a-z0-9.$~_'); | |||
There was a problem hiding this comment.
shouldn't this also update the regex ?
There was a problem hiding this comment.
This is mostly to normalize the domain and url path. Domain can't contain underscore and path to the packages.json is also not really relevant here I think.
emahorvat52
pushed a commit
to emahorvat52/composer
that referenced
this pull request
Feb 3, 2023
… containing underscore vs dashes, fixes composer#11224 (composer#11229)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11224