Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClassLoader to be serializable #11237

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Conversation

Seldaek
Copy link
Member

@Seldaek Seldaek commented Dec 22, 2022

@mariano-dagostino
Copy link

@Seldaek Thanks! I confirm this fixes the problem I reported here sebastianbergmann/phpunit#5117

@stobrien89
Copy link

Will this be included in a new release today? Our Github CI is currently broken.

@Seldaek Seldaek added this to the 2.5 milestone Dec 22, 2022
@Seldaek Seldaek added the Bug label Dec 22, 2022
@Seldaek Seldaek merged commit cbb7c91 into composer:main Dec 22, 2022
@Seldaek Seldaek deleted the classmap_serializable branch December 22, 2022 14:17
@Seldaek
Copy link
Member Author

Seldaek commented Dec 22, 2022

Yup, it's out now https://github.com/composer/composer/releases/tag/2.5.1

@stobrien89
Copy link

Thanks @Seldaek!

Can confirm the issue is resolved for us.

emahorvat52 pushed a commit to emahorvat52/composer that referenced this pull request Feb 3, 2023
* Fix ClassLoader to be serializable

* Fix CI to use the source bin/composer as process for "composer" runs incl within simple-phpunit

* Store the closure statically to avoid serialization issues in a cleaner way
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants