Repository navigation
Add support for --minimal-changes with full updates - #12349
Conversation
|
Looks good, just wonder if there should be an error/warning if --minimal-changes is used on a full update and the composer.json is unmodified, which will never result in any modifications? |
|
Well.. you ask for minimal updates you get minimal updates :p |
| { "name": "dependency/pkg", "version": "2.0.0" }, | ||
| { "name": "dependency/pkg", "version": "1.1.0" }, | ||
| { "name": "dependency/pkg", "version": "1.0.0" }, | ||
| { "name": "dependency/pkg2", "version": "2.0.0" }, |
There was a problem hiding this comment.
I suggest having both 2.0.0 and 2.1.0 (which would both match the requirement), to cover that --minimal-changes will still update to 2.1.0 and not to 2.0.0 (i.e. it is not the --minimal-deviation that was suggested in the discussion)
There was a problem hiding this comment.
Done in 12221a3 (I think that's what you meant anyway)
|
IIUC this update: if you didn't update In that case I do agree with @naderman about unmodified |
|
Yes, I'll see if we can easily add a warning or not. |
Refs #12341