Dist directory fetcher #1266

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

Flyingmana commented Oct 27, 2012

For development purposes it is cool to be able to fetch packages from the local filesystem.

Some VCS allow this, but they depend on committed changes, they do now allow using the version on the filesystem direct.

For this I added an additional downloader which is able to copy local directories into vendor.

This needed two changes:

  1. add a method to the filesystem class to copy a directory recusrive (I tried to create it similar to the existent functions, but did not test the windows version of it)
  2. add the downloader

Now the question is, what is needed to get the changes accepted or how to integrate this functionality from extern.

Owner

Seldaek commented Oct 27, 2012

Might be a dumb question but why not just developing in the vendor dir?

Contributor

Flyingmana commented Oct 27, 2012

a valid question

Its caused by the incremental evolution of projects.

dependency A of project B was created first, and if you use the same dependency over more than one project, it starts to get confusing.

Contributor

fprochazka commented Oct 28, 2012

related? #1017

Contributor

Flyingmana commented Oct 28, 2012

yes, a lot overhead by adding the link beside and not inside the dist part, but basically yes.

Owner

Seldaek commented Oct 28, 2012

Yeah but I think the link approach is the most viable, although a bit annoying; I don't really see what this PR will do with regards to versions and stuff like that. You can just use it to mirror a directory whenever you rm -rf vendor/foo/bar && composer install right? Might as well cp -rp foo vendor/foo/bar directly if that's all you get from it IMO.

Contributor

Flyingmana commented Oct 28, 2012

I close this Pull Request, as it is not needed anymore.
we can add own downloader via custom installers if we overwrite installCode(), so we dont need to include it into composer

@Flyingmana Flyingmana closed this Oct 28, 2012

@chEbba chEbba referenced this pull request Nov 19, 2012

Closed

WIP: Link command #1017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment