Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Added addLink and removeLink to Configuration Source Interface #1327

Merged
merged 1 commit into from

2 participants

@simensen
  • Added addLink() and removeLink() to ConfigSourceInterface
  • Added addLink() and removeLink() implementations to JsonConfigSource
  • Added tests (+ a ton of fixtures) for JsonConfigSource
  • Added additional docblocks
  • Minor PSR-1/PSR-2 fixes here and there

I put a lot of work into the testing. I wasn't sure it was required as it sorta felt like I was just testing JsonManipulator, but who knows what is going to be going on in the future? This should hopefully future proof it as far as testing is concerned, especially if the links are handled/validated by JsonManipulator (or whatever) on a case-by-case basis in the future?

Anyway, it is kind of nice to know that "given this is the composer.json before, that is what it will look like after," so maybe it was worth it.

If we don't need it I can take it out.

I'll work on adding commands (require foo/project --dev --remove, provide foo/interface, etc.) once this gets merged.

@simensen simensen Added addLink and removeLink to Configuration Source Interface
 * Added addLink() and removeLink() to `ConfigSourceInterface`
 * Added addLink() and removeLink() implementations to `JsonConfigSource`
 * Added tests (+ a ton of fixtures) for `JsonConfigSource`
 * Added additional docblocks
 * Minor PSR-1/PSR-2 fixes here and there
752fa64
@Seldaek
Owner

Hah ok I didn't expect that much when I read lot of work into the testing ;) But sure since this should not change at all anyway it doesn't hurt too much. Looks good thanks.

@Seldaek Seldaek merged commit ef0151e into from
@felixalias felixalias referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@simensen simensen deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 14, 2012
  1. @simensen

    Added addLink and removeLink to Configuration Source Interface

    simensen authored
     * Added addLink() and removeLink() to `ConfigSourceInterface`
     * Added addLink() and removeLink() implementations to `JsonConfigSource`
     * Added tests (+ a ton of fixtures) for `JsonConfigSource`
     * Added additional docblocks
     * Minor PSR-1/PSR-2 fixes here and there
Something went wrong with that request. Please try again.