Added addLink and removeLink to Configuration Source Interface #1327

Merged
merged 1 commit into from Nov 15, 2012

Conversation

Projects
None yet
2 participants
Contributor

simensen commented Nov 14, 2012

  • Added addLink() and removeLink() to ConfigSourceInterface
  • Added addLink() and removeLink() implementations to JsonConfigSource
  • Added tests (+ a ton of fixtures) for JsonConfigSource
  • Added additional docblocks
  • Minor PSR-1/PSR-2 fixes here and there

I put a lot of work into the testing. I wasn't sure it was required as it sorta felt like I was just testing JsonManipulator, but who knows what is going to be going on in the future? This should hopefully future proof it as far as testing is concerned, especially if the links are handled/validated by JsonManipulator (or whatever) on a case-by-case basis in the future?

Anyway, it is kind of nice to know that "given this is the composer.json before, that is what it will look like after," so maybe it was worth it.

If we don't need it I can take it out.

I'll work on adding commands (require foo/project --dev --remove, provide foo/interface, etc.) once this gets merged.

@simensen simensen Added addLink and removeLink to Configuration Source Interface
 * Added addLink() and removeLink() to `ConfigSourceInterface`
 * Added addLink() and removeLink() implementations to `JsonConfigSource`
 * Added tests (+ a ton of fixtures) for `JsonConfigSource`
 * Added additional docblocks
 * Minor PSR-1/PSR-2 fixes here and there
752fa64
Owner

Seldaek commented Nov 15, 2012

Hah ok I didn't expect that much when I read lot of work into the testing ;) But sure since this should not change at all anyway it doesn't hurt too much. Looks good thanks.

@Seldaek Seldaek added a commit that referenced this pull request Nov 15, 2012

@Seldaek Seldaek Merge pull request #1327 from simensen/config-add-remove-link
Added addLink and removeLink to Configuration Source Interface
ef0151e

@Seldaek Seldaek merged commit ef0151e into composer:master Nov 15, 2012

1 check failed

default The Travis build failed
Details

simensen deleted the simensen:config-add-remove-link branch May 3, 2013

@digitalkaoz digitalkaoz pushed a commit to digitalkaoz/composer that referenced this pull request Nov 22, 2013

@Seldaek Seldaek Merge pull request #1327 from simensen/config-add-remove-link
Added addLink and removeLink to Configuration Source Interface
1dee246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment