Use local mirror of git repository in GitDownloader #1338

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@chEbba
Contributor
chEbba commented Nov 18, 2012

Simple Implementation of #1323

Clone repository from mirrored local one instead of remote.

I tested few scenarios and got the following results on my linux VM with symfony-standard dev project:

  • current composer version: ~196s for composer install
  • mirror + reference: ~57s
  • mirror + direct clone from mirror: ~25s

Does anyone see any drawbacks of this type of solution?
Any comments about using GitDriver in downloader?

Contributor
chEbba commented Nov 18, 2012

Downloader tests need to be fixed. Will do that if concept will be approved.

Contributor
chEbba commented Nov 18, 2012

Also --shared flag can be used to reduce the space

Contributor

Related? #1017

Contributor
chEbba commented Nov 19, 2012

I don't think it is really related to #1017 because it just use local git repo instead of remote one to reduce traffic. Also i don't see how cvs repository linking can be done.
But I think some ideas from my another PR may be useful. Will comment there.

Owner
Seldaek commented Nov 19, 2012

--shared would be nice to have, but I think it should be optional because if you clear the cache dir you would probably break the checkouts.

Owner
Seldaek commented Nov 19, 2012

And by optional I mean $config->get('share-git') or something like that, not a command line option.

@Seldaek Seldaek closed this Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment