Allow to bind closures to the EventDispatcher #1951
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting... Would love to see this develop. |
| if ($this->isPhpScript($callable)) { | ||
| if ($this->isCallable($callable)) { | ||
| try { | ||
| $callable($event); |
There was a problem hiding this comment.
this is not the right way to call a callable on PHP 5.3
| * @param unknown_type $callable Something we will decide whether it's a callable | ||
| * @return boolean | ||
| */ | ||
| protected function isCallable($callable) |
There was a problem hiding this comment.
Why do you wrap the simple native call into a method?
There was a problem hiding this comment.
ah, heh. That used to be more complicated :) that can be inlined by now
Merge latest stuff from composer
Conflicts: src/Composer/EventDispatcher/EventDispatcher.php tests/Composer/Test/EventDispatcher/EventDispatcherTest.php
|
I think a better fix now that we have plugins would be to modify the plugin system to allow hooking into any existing "script" event from plugins. Any comments on this @naderman? |
|
Seems the same / very similar thing has been done in 3960edd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are right now two ways that I know of that are possible to allow to get a trigger in a custom installer
__destruct()(ugly)I would like to be able to subscribe to events because I'm building a custom installer that does some code generation based on the contents of the to-be-installed package. Part of the code that I generate depends on the combination of the installed packages.
i.e. I generate some "glue" between them. So I need a hook where I can get the complete list of packages, after they have all been installed.
My gut feeling told me to bind to the EventDispatcher, but there was no possibility for that. Hence this pull request + unit tests :)