Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

PHP 5.3.2 segmentation fault fix #226

Merged
merged 1 commit into from Jan 19, 2012

Conversation

Projects
None yet
4 participants
Contributor

justinrainbow commented Jan 18, 2012

For some reason, using the SqlFixedArray causes a Segmentation Fault during an install or update. Changing to a simple array fixes this issue, but in turn uses more memory. Which is why there is the version test.

This is a fix for #211 and has been verified working on a CentOS 5.6 machine running PHP 5.3.2

@justinrainbow justinrainbow PHP 5.3.2 segmentation fault fix
For some reason, using the SqlFixedArray causes a Segmentation Fault during
an install or update.  Changing to a simple array fixes this issue, but in
turn uses more memory.  Which is why there is the version test.
7eda0a8
Contributor

stloyd commented Jan 18, 2012

Hehe, why I didn't found this ;-) Few weeks ago I fixed tests for Symfony2 by same reason :-)

Contributor

simensen commented Jan 19, 2012

If this does indeed fix PHP 5.3.2 that would be most excellent. :)

Owner

Seldaek commented Jan 19, 2012

Is it only causing segfaults for 5.3.2 + suhosin, or also standard 5.3.2? Because if suhosin is in cause, it would be great to only use more memory when it's present.

Contributor

simensen commented Jan 19, 2012

Can suhosin be installed without changing the --version output? In my limited experience (Ubuntu, OSX) the --version output includes "with Suhosin-Patch." Is that always true? If we can trust that it would say suhosin if it was patched, I would say that we can call this a PHP 5.3.2 fix and not worry about checking for suhosin in the code.

For what it is worth, it looks like this segfault happens on Travis and the output of php --version on the PHP builders does not include anything about suhosin.

http://travis-ci.org/#!/composer/composer/jobs/532616

Owner

Seldaek commented Jan 19, 2012

Alright, I guess people running old PHP better have lots of RAM then :) Let's merge and see if reports of crash go down. Thanks!

@Seldaek Seldaek added a commit that referenced this pull request Jan 19, 2012

@Seldaek Seldaek Merge pull request #226 from justinrainbow/bug_211
PHP 5.3.2 segmentation fault fix
f6efa3a

@Seldaek Seldaek merged commit f6efa3a into composer:master Jan 19, 2012

@digitalkaoz digitalkaoz pushed a commit to digitalkaoz/composer that referenced this pull request Nov 22, 2013

@Seldaek Seldaek Merge pull request #226 from justinrainbow/bug_211
PHP 5.3.2 segmentation fault fix
a40f57e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment