More refactoring for AutoloadGenerator #2298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actored out into AutoloadGeneratorHelper.
… of just creating the code.
…y being used in dumpAutoloadRealFile(), it just wasn't an explicit property)
… 2. Fight paramter madness by introducing a AutoloadGenerationTask lazy value container.
|
@Seldaek: Please don't merge this as-is. I want to clean up the git history (rebase) and we probably want to rename some methods.. |
|
And merging with master is going to be fun... |
| { | ||
| // Add custom psr-0 autoloading, if the root package has a target dir. | ||
| $mainAutoload = $this->mainPackage->getAutoload(); | ||
| if (1 |
There was a problem hiding this comment.
to line up the && nicely, and make it easy to rearrange conditions.. similar to the comma after a last element in an array.
i don't insist on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to the refactoring PR for AutoloadGenerator. #2142
Goal: