Add preFileDownload event on packages.json fetch #2434
Conversation
| private $rawData; | ||
| private $minimalPackages; | ||
| private $degradedMode = false; | ||
| private $rootData; | ||
|
|
||
| public function __construct(array $repoConfig, IOInterface $io, Config $config) | ||
| public function __construct(array $repoConfig, IOInterface $io, Config $config, EventDispatcher $eventDispatcher = null) |
There was a problem hiding this comment.
is there a use case for making it nullable ?
There was a problem hiding this comment.
not really, just following the existing ;)
|
I see a drawback in this PR: it introduces some cyclic dependency graph: Composer depends on RepositoryManager which depends on EventDispatcher, which depends on Composer. This is not really clean |
|
I just reorganized this code, in order to make possible to inject EventManager into RepositoryManager, but i saw it and your right, it's not really clean. |
|
👍 will allow us to secure our packages.json file on our instance of satis |
|
@stof it's not great but I'm not sure there is a way around this. |
Add preFileDownload event on packages.json fetch
|
Breaks entirely: #2444 |
|
(:-1:) Same problem here. |
|
👎 :-( |
|
Why does VcsRepository break standard repository composition? is this argument ($driver) really used? |
Hi,
In order to extend @naderman's work on pluggin system, this add a
PreFileDownloadEventdispatch when composer fetch packages.json (For ComposerRepository class).It's usefull for us, because we need to fetch it using
s3://scheme.Thanks,
Jérémy