testParseErrorDetectSingleQuotes() fails on pecl-json-c #2458
Conversation
… on some PHP configurations.
|
Meant to fix #2457 |
| // The regular PHP json extension does not accept single quotes. | ||
| // However, some versions of pecl-json-c do accept them, causing this | ||
| // test to fail. This is fixed in | ||
| // https://github.com/remicollet/pecl-json-c/commit/c15ddc2a95fece22a65a05eeeb4bfdd63a745273 |
There was a problem hiding this comment.
Linking to this commit is misleading because if you look at the current README, that PR has been merged upstream in json-c. So what we are actually waiting for is a release of json-c with that fix, and ubuntu/debian to ship that fix also.
|
what about using skipTest instead in case json-c extension is loaded? maybe with a additional if case for the json-c version.. |
|
@staabm: The next version of json-c could have this fixed already. |
|
I'd tend towards the "not my bug, don't care" resolution for this :) Given it's a temporary issue that will hopefully be soon resolved I think it's safe to just ignore. If you want to do something about it though then feel free but then the json_decode test you suggested is probably a better idea, because just adding a comment still means people will waste time. |
Adding a comment to explain why testParseErrorDetectSingleQuotes() fails on some PHP configurations.
I would also add a message to be printed when the test fails, but expectParseException does not currently accept a parameter. Too lazy to change that.. (and prefer to work on the PSR-4 stuff)