New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check exclude from downloaded composer.json #2482

Merged
merged 1 commit into from Dec 5, 2013

Conversation

Projects
None yet
3 participants
@oziks
Contributor

oziks commented Dec 5, 2013

Hi !

I met a problem when archiving a repo from packagist.

https://github.com/liip/LiipImagineBundle has a composer archive property which excludes a directory from the archive. But it seems it does not work because packagist doesn't give this property.

Thanks to @adriensamson for your help ;)

Seldaek added a commit that referenced this pull request Dec 5, 2013

Merge pull request #2482 from oziks/fix-composer-archive-property
Check exclude from downloaded composer.json

@Seldaek Seldaek merged commit 43fde91 into composer:master Dec 5, 2013

1 check passed

default The Travis CI build passed
Details
@Seldaek

This comment has been minimized.

Show comment
Hide comment
@Seldaek

Seldaek Dec 5, 2013

Member

Thanks

Member

Seldaek commented Dec 5, 2013

Thanks

@oziks oziks deleted the oziks:fix-composer-archive-property branch Dec 5, 2013

@oziks

This comment has been minimized.

Show comment
Hide comment
@oziks

oziks Dec 5, 2013

Contributor

Thanks

Contributor

oziks commented Dec 5, 2013

Thanks

@lcf

This comment has been minimized.

Show comment
Hide comment
@lcf

lcf Dec 10, 2013

This, most likely, have broken our satis build: "file_get_contents(/tmp/composer_archiver/apache-thrift-0.9.1-c406f1/composer.json): failed to open stream: No such file or directory". (we rolled back to an earlier revision since, so not sure if this has been taken already)

This, most likely, have broken our satis build: "file_get_contents(/tmp/composer_archiver/apache-thrift-0.9.1-c406f1/composer.json): failed to open stream: No such file or directory". (we rolled back to an earlier revision since, so not sure if this has been taken already)

This comment has been minimized.

Show comment
Hide comment
@oziks

oziks Dec 10, 2013

Contributor

Does the package apache-thrift-0.9.1 contains a composer.json file ?

Contributor

oziks replied Dec 10, 2013

Does the package apache-thrift-0.9.1 contains a composer.json file ?

This comment has been minimized.

Show comment
Hide comment
@lcf

lcf Dec 10, 2013

no, but they don't always have them, right?
This repository-package is configured "manually" like this: https://gist.github.com/lcf/ecaccef8a0546dd9d80f

lcf replied Dec 10, 2013

no, but they don't always have them, right?
This repository-package is configured "manually" like this: https://gist.github.com/lcf/ecaccef8a0546dd9d80f

This comment has been minimized.

Show comment
Hide comment
@oziks

oziks Dec 10, 2013

Contributor

PR #2496

Contributor

oziks replied Dec 10, 2013

PR #2496

This comment has been minimized.

Show comment
Hide comment
@Seldaek

Seldaek Dec 26, 2013

Member

@lcf the fix has been merged.

Member

Seldaek replied Dec 26, 2013

@lcf the fix has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment