Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to docs that replacing third party packages is bad practice #2488

Closed
wants to merge 1 commit into from

Conversation

igorw
Copy link
Contributor

@igorw igorw commented Dec 8, 2013

No description provided.

@max-voloshin
Copy link
Contributor

@igorw , really? /cc: @naderman

@stof
Copy link
Contributor

stof commented Dec 14, 2013

@max-voloshin If you replace a package you don't not own and you publish your replacing package, users asking for the original package may receive your replacement (and fail to understand why)

@max-voloshin
Copy link
Contributor

@stof, good notice, thank you!

But I think that

  1. Documentation should explain where is problem. Assertion "replacing third party packages is bad practice" is not completed IMO, because publishing these packages is problem, not replacing.
    I can replace third party packages in my private environment without any problems for anyone.
  2. Looks like this is Packagist issue to deny publishing packages, which replace packages of other vendors.

@naderman
Copy link
Member

Sorry but this is incorrect. Replace does have a purpose, and that does include replacing packages you do not own. And it does include publishing them. Yes this may not be what users expect in some situations but that doesn't mean it isn't exactly what one wants to do in other situations, so I disagree with adding this note.

@naderman naderman closed this Dec 16, 2013
@stof
Copy link
Contributor

stof commented Dec 16, 2013

@naderman We should still warn people that they should be careful when using replace. It has been misused several times leading to WTF for users thinking that composer was doing crap. It is even worse when a packages is published with a replacement for * versions

@naderman
Copy link
Member

@stof Sure I'm fine with that, but then it should be phrased differently. @igorw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants