Autoload generator refactor #2563
Conversation
| 'psr-0' => array('A\\B' => $this->workingDir.'/lib'), | ||
| 'classmap' => array($this->workingDir.'/src') | ||
| )); | ||
| $mainPackage->setRequires(array(new Link('z', 'a/a'))); |
There was a problem hiding this comment.
Please refrain from doing ANY changes to tests in this PR. Send them in a separate PR if you must, so they can be checked against the existing code.
There was a problem hiding this comment.
I will isolate these changes in the next or an upcoming rebase.
(I think they are already speparate commits, but I will make an isolated PR)
There was a problem hiding this comment.
Factored out into #2666
|
The testing stuff is now isolated into a separate commit, and merged into master. |
| * | ||
| * @return PluginInterface[] | ||
| */ | ||
| protected function createPreparedPlugins(PackageMap $packageMap, $scanPsr0Packages) |
There was a problem hiding this comment.
The naming of this method is confusing
| */ | ||
| public function addArraySourceFile($filename, $phpRows) | ||
| { | ||
| $this->arraySourceFiles[$filename] = $phpRows; |
There was a problem hiding this comment.
Not sure - would want a 3rd opinion.
Imo, if this method is called with something other than a string, then something is going wrong, and i want to see it crash loud and clear, instead of a silent type cast. Or we simply let the IDE do the type checks for us. But that's just me.
@Others?
There was a problem hiding this comment.
I don't really care for string casts. It's just noise IMO especially since it'll be automatically casted to a string when it's used as such later.
|
Think it's probably time to close this.. |
Don't pull this yet, this is in review / demo stage.
I am going to rebase this quite a lot in the next days.
See Issue #2460: AutoloadGenerator refactoring - strategy talk
Known issues:
Fixed issues:
Solution: This was now factored out into Autoload generator test improvements #2666, and merged into master.
Solution: Not it is all squashed into one commit.