Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

"artifact" type repo creates absolute paths in .lock file #2698

Merged
merged 1 commit into from Jul 19, 2014

Conversation

Projects
None yet
2 participants
Contributor

mpdude commented Feb 18, 2014

The "artifact" type repository can take a relative path to a directory containing .zip files.

However, the .lock file will contain absolute paths to the installed package .zip files. Obviously that's a problem when someone else tries to install from this lock file with a checkout in another location.

@Seldaek Seldaek added Feature Bug and removed Feature labels Feb 13, 2014

@Seldaek Seldaek added this to the Bugs milestone Feb 13, 2014

Contributor

mpdude commented Feb 15, 2014

Does it make sense to have an artifacts folder that is not below your root package?

Owner

Seldaek commented Feb 18, 2014

@mpdude yes people use network mounts somewhere on their machine containing all the artifacts of their company for example. I don't really know if we can fix this though. Having a relative path to a parent folder would probably not help a lot..

@mpdude mpdude This should create relative/absolute dist URLs depending on the way (…
…relative/absolute) the artifact directory path was given.
beff1f5
Contributor

mpdude commented Feb 18, 2014

So what about this...? What am I missing?

Contributor

mpdude commented Jul 1, 2014

@Seldaek What do you think - does this solve the problem? This would use absolute/relative paths depending on the way the artifact is referenced.

Owner

Seldaek commented Jul 19, 2014

I guess it's fine to merge. Thanks and sorry for the delay..

@Seldaek Seldaek merged commit beff1f5 into composer:master Jul 19, 2014

1 check passed

default The Travis CI build passed
Details

@mpdude mpdude deleted the unknown repository branch Oct 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment