New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist packages with names matching those specified before generating rules #2733

Merged
merged 4 commits into from Feb 21, 2014

Conversation

Projects
None yet
2 participants
@naderman
Member

naderman commented Feb 21, 2014

Addresses #2690 but doesn't do any performance optimizations yet which we
could do now

Whitelist packages with names matching those specified before generat…
…ing rules

Addresses #2690 doesn't do any performance optimisations yet which we
could do now
@naderman

This comment has been minimized.

Show comment
Hide comment
@naderman

naderman Feb 21, 2014

Member

Working on another test, this doesn't seem to work quite right yet.

Member

naderman commented Feb 21, 2014

Working on another test, this doesn't seem to work quite right yet.

@naderman

This comment has been minimized.

Show comment
Hide comment
@naderman

naderman Feb 21, 2014

Member

Added tests for the changes in this PR and it seems to be working now.

Member

naderman commented Feb 21, 2014

Added tests for the changes in this PR and it seems to be working now.

naderman added a commit that referenced this pull request Feb 21, 2014

Merge pull request #2733 from naderman/limit-replace-provide
Whitelist packages with names matching those specified before generating rules

@naderman naderman merged commit 33e872d into composer:master Feb 21, 2014

1 check passed

default The Travis CI build passed
Details
{
if (isset($this->providerCache[$name][(string) $constraint])) {
return $this->providerCache[$name][(string) $constraint];
$key = ((string) (int) $mustMatchName).((string) $constraint);

This comment has been minimized.

@stof

stof Feb 21, 2014

Contributor

no need to cast to string explicitly. the concatenation operator already does it

@stof

stof Feb 21, 2014

Contributor

no need to cast to string explicitly. the concatenation operator already does it

This comment has been minimized.

@naderman

naderman Feb 21, 2014

Member

Good point

@naderman

naderman Feb 21, 2014

Member

Good point

This comment has been minimized.

@naderman

naderman Feb 21, 2014

Member

Fixed in eb5c785

@naderman

naderman Feb 21, 2014

Member

Fixed in eb5c785

filbertkm added a commit to wmde/WikidataBuilder that referenced this pull request Feb 24, 2014

filbertkm added a commit to wmde/puppet-composer that referenced this pull request Feb 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment