PHPCS: code style errors detection and fixes

[MacDada]

Contributing section mentions that the code should follow Symfony coding standards.

I added PHP_CodeSniffer as a dev requirement and applied fixes to detected errors.

If you don't want composer.json changed, I can remove it from the commit.

There are 2 errors that cannot be fixed simply:

• CreateProjectCommand->installProject() should put required arguments first, optional later.
• JsonConfigSource->array_unshift_ref() has no visibility set and is under_score style. Because it's public by default, chaning that might be a BC break.

[stof]

The previous code was fine according to PSR-2. The function call was single-line (even though there was a multiline string in one of the arguments)

[MacDada]

Then it might be a phpcs bug, but if we are to encourage people to use it, I would have the line changed anyway – so that phpcs doesn't report any errors anymore and contributors have a clear view.

The report:

FILE: composer/src/Composer/Autoload/ClassMapGenerator.php
--------------------------------------------------------------------------------
FOUND 5 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
 147 | ERROR | Opening parenthesis of a multi-line function call must be the
     |       | last content on the line
     |       | (PSR2.Methods.FunctionCallSignature.ContentAfterOpenBracket)
 152 | ERROR | Only one argument is allowed per line in a multi-line function
     |       | call (PSR2.Methods.FunctionCallSignature.MultipleArguments)
 152 | ERROR | Only one argument is allowed per line in a multi-line function
     |       | call (PSR2.Methods.FunctionCallSignature.MultipleArguments)
 152 | ERROR | Closing parenthesis of a multi-line function call must be on a
     |       | line by itself
     |       | (PSR2.Methods.FunctionCallSignature.CloseBracketLine)
 164 | ERROR | Line indented incorrectly; expected at least 20 spaces, found 18
     |       | (Generic.WhiteSpace.ScopeIndent.Incorrect)
--------------------------------------------------------------------------------

[stof]

this is the same PHPCS bug than the other one.

[MacDada]

This one should get fixed in the near future:
Fixed:
squizlabs/PHP_CodeSniffer#211

[Seldaek]

Thanks but no thanks. I have no love for angry CS tools.