Allow to select virtual packages in init command - #3322
Merged
Conversation
Seldaek
added a commit
that referenced
this pull request
Oct 7, 2014
Member
|
Thanks, I changed the patch a bit though to actually fix it where it started so as to avoid any further issues with the search functionality. |
Author
|
NP - Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems matches returns virtual packages with their keys the same as their name. This means you can't actually select them when prompted:
It's a simple fix by using
array_valueson the return offindPackagesLet me know if i've overlooked something, I also looked where to add a test but couldn't really see any existing tests for the command internals.