Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to select virtual packages in init command #3322

Merged
merged 1 commit into from Oct 7, 2014

Conversation

@AydinHassan
Copy link
Contributor

commented Oct 2, 2014

It seems matches returns virtual packages with their keys the same as their name. This means you can't actually select them when prompted:

It's a simple fix by using array_values on the return of findPackages

Let me know if i've overlooked something, I also looked where to add a test but couldn't really see any existing tests for the command internals.

Aydin

@Seldaek Seldaek merged commit 432cdbc into composer:master Oct 7, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

Seldaek added a commit that referenced this pull request Oct 7, 2014

@Seldaek

This comment has been minimized.

Copy link
Member

commented Oct 7, 2014

Thanks, I changed the patch a bit though to actually fix it where it started so as to avoid any further issues with the search functionality.

@AydinHassan

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2014

NP - Thanks :)

@AydinHassan AydinHassan deleted the AydinHassan:hotfix/init-virtual-packages branch Oct 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.