Upgrade DialogHelper to QuestionHelper #3983
Conversation
| * @param string $author | ||
| * @return array | ||
| */ | ||
| public function parseAuthorString($author) |
There was a problem hiding this comment.
public methods should stay before protected ones (and avoiding to move the code around like this also makes the review easier)
There was a problem hiding this comment.
I agree on the review aspect, but it's kinda private anyway, it's only public because it has to be used by a closure, so in that case maybe tagging it with @private and moving it down makes more sense.
There was a problem hiding this comment.
Oh, I'm sorry. I'm just so used to putting helper methods after the config and execute methods. I'll revert that change.
Edit: marked it as @private instead.
|
This change currently requires bumping the Console requirement to 2.5+ (because it supports only the new API), and this is not possible yet because Packagist still runs on Symfony 2.3 and it needs Composer. |
|
We already require 2.5, and I can live with that for now.. |
|
I was about to say.. https://github.com/composer/composer/blob/master/composer.json#L28 |
|
Thanks! |
Upgrade DialogHelper to QuestionHelper
Closes #3760