Move VersionParser::formatVersion() to BasePackage::getFullPrettyVersion() #4086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| return $package->getPrettyVersion() . ' ' . $package->getSourceReference(); | ||
| return $package->getFullPrettyVersion($truncate); |
There was a problem hiding this comment.
It's ok for me to keep this around but I think it should do a trigger_error('VersionParser::formatVersion is deprecated, you should use $package->getFullPrettyVersion() instead', E_USER_DEPRECATED);
There was a problem hiding this comment.
Indeed. Along with a @deprecated annotation. That way you could easily catch it in Composer 2.0.
| return $package->getPrettyVersion() . ' ' . $package->getSourceReference(); | ||
| trigger_error(__METHOD__.' is deprecated. Use '. | ||
| '\Composer\Package\PackageInterface::getFullPrettyVersion() instead', E_USER_DEPRECATED); | ||
| return $package->getFullPrettyVersion($truncate); |
There was a problem hiding this comment.
Empty line before return construct.
…ion() Working towards composer#3545. formatVersion() does not belong in VersionParser since it depends upon a Package object, and is creating a more complete pretty formatted version, not parsing anything. The new getFullPrettyVersion() method can be seen as an extension to getPrettyVersion(), and is located in BasePackage as a result. Callers to VersionParser::formatVersion() were not updated in this commit to demonstrate that no functionality was changed in this refactor. They will be updated in a follow up commit.
Tests were moved to BasePackageTest.
With 1753c27, this will be handled nicely.
|
Fixed code style, rebased against master, and then fixed failing tests due to a missing namespace import. |
Seldaek
added a commit
that referenced
this pull request
Jul 3, 2015
Move VersionParser::formatVersion() to BasePackage::getFullPrettyVersion()
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards #3545.
formatVersion() does not belong in VersionParser since it depends upon a
Package object, and is creating a more complete pretty formatted
version, not parsing anything.
The new getFullPrettyVersion() method can be seen as an extension to
getPrettyVersion(), and is located in BasePackage as a result.
I'm also not very good at naming things, and
getFullPrettyVersionwas the best I could come up with. Better suggestions welcome :)